← Back to team overview

mahara-contributors team mailing list archive

[Bug 1689312] Re: New username isn't checked for spaces when added to LDAP

 

Hi Matt,

Thanks for this report. If you'd like to submit your solution for Mahara
core, we'd love to see it. You can find information on how to set up
your connection to our code review system at
https://wiki.mahara.org/wiki/Developer_Area/Contributing_Code

Or since it's your first fix for Mahara, if you want to submit it here
to Launchpad as a patch file, we can push it into our review system.

Cheers
Kristina


** Changed in: mahara
       Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
    Milestone: None => 17.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689312

Title:
  New username isn't checked for spaces when added to LDAP

Status in Mahara:
  Confirmed

Bug description:
  Mahara version: 16.10.3

  When adding a new user, if you select an institution/authentication
  method with LDAP, the usersame is not being checked for
  leading/trailing spaces, and it isn't trimmed before being added to
  the database. Users can be created with usernames like " newuser ".

  If you try to do this with a non LDAP authentication method, it thows
  an error and will not continue (although the error message does not
  highlight the username field as the source of the error in this case).

  I've fixed it locally with trim() around the username value before
  it's put into the databse.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689312/+subscriptions


References