mahara-contributors team mailing list archive

[Mahara Bot <1681291@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7737
Committed: https://git.mahara.org/mahara/mahara/commit/fee994ca330cb614a084cd169e7c39f2a06b591f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit fee994ca330cb614a084cd169e7c39f2a06b591f
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon May 8 11:04:13 2017 +1200

Bug 1681291: Missing params for LeapImportComment::setup_relationships()

When the bug 1643365 was fixed we missed a place where the
setup_relationships() was called. We need to add the extra required
parameters to the call

behatnotneeded

Change-Id: I093937073598d4ff39abfa10aa9725319a40ec55
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit a407b3791a85b59c1a83d50216d187cc7a53905f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681291

Title:
  Unable to import leap2a file

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Tested on
  Site: https://master-mahara.catalystdemo.net.nz
  Browser: chrome/FF/Safari 10.0.3
  Device: Desktop/MacBook Pro

  Steps to Reproduce:

  1) Navigate to portfolio>Import
  2) choose a Leap2a file
  3) Click on Import

  Actual Result: The following warning message is displayed

  [WAR] 1d (artefact/comment/import/leap/lib.php:249) Missing argument 3
  for LeapImportComment::setup_relationships(), called in
  /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php
  on line 240 and defined

  
  Call stack (most recent first):
  log_message("Missing argument 3 for LeapImportComment::setup_re...", 8, true, true, "/home/niranjanbandi/code/mahara/htdocs/artefact/co...", 249) at /home/niranjanbandi/code/mahara/htdocs/lib/errors.php:521
  error(2, "Missing argument 3 for LeapImportComment::setup_re...", "/home/niranjanbandi/code/mahara/htdocs/artefact/co...", 249, array(size 2)) at /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php:249
  LeapImportComment::setup_relationships(object(SimpleXMLElement), object(PluginImportLeap)) at /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php:240
  LeapImportComment::setup_relationships_from_requests(object(PluginImportLeap)) at /home/niranjanbandi/code/mahara/htdocs/lib/mahara.php:1771
  call_static_method("LeapImportComment", "setup_relationships_from_requests", object(PluginImportLeap)) at /home/niranjanbandi/code/mahara/htdocs/import/leap/lib.php:299
  PluginImportLeap->call_import_method_plugins("setup_relationships_from_requests") at /home/niranjanbandi/code/mahara/htdocs/import/leap/lib.php:315
  PluginImportLeap->do_import_from_requests() at /home/niranjanbandi/code/mahara/htdocs/import/index.php:311
  do_import() at /home/niranjanbandi/code/mahara/htdocs/import/index.php:71

  [WAR] 1d (lib/errors.php:536) [TypeError]: Argument 4 passed to
  LeapImportComment::setup_relationships() must be of the type array,
  none given, called in
  /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php
  on line 240

  Call stack (most recent first):
  exception(object(TypeError)) at Unknown:0

  And for safari browser it only shows the following error

  
  Mahara: Site unavailable
  A nonrecoverable error occurred. This probably means you have encountered a bug in the system

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681291/+subscriptions