mahara-contributors team mailing list archive

[Mahara Bot <1694155@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7792
Committed: https://git.mahara.org/mahara/mahara/commit/dc821b27ff801b5b11cfacde94dd8fbcdab066f1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit dc821b27ff801b5b11cfacde94dd8fbcdab066f1
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon May 29 07:33:38 2017 +1200

Bug 1694155: Return new block id when calling View->addblocktype

behatnotneeded

Change-Id: Id024139fdff2f11aaa916d93df13f03614ad227c
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1694155

Title:
  Allow addblocktype to return id of new block instance

Status in Mahara:
  Fix Committed

Bug description:
  Currently if we add a block to a page via a new BlockInstance we need
  to add the block as the last in sort order.

  But we can't add the block at a specific sort order due to clashing
  with existing blocks.

  However the View->addblocktype can handle adding a block as a certain
  point by using the private function shuffle_cell but this function
  only returns the rendered html of the block if 'returndata' is set.

  I'll add ability to return new blockinstance id if 'returndata' ===
  'id' as an option

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1694155/+subscriptions