← Back to team overview

mahara-contributors team mailing list archive

[Bug 1696587] A change has been merged

 

Reviewed:  https://reviews.mahara.org/7808
Committed: https://git.mahara.org/mahara/mahara/commit/d85a81d05b4575594019eb28d29aea1086a644e4
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit d85a81d05b4575594019eb28d29aea1086a644e4
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Jun 6 14:09:24 2017 +1200

Bug 1696587: Only replace the missing view_row_columns records if the
view has an id

To avoid problem when creating a view from import when layout is
specified by creating a dummy view to create the layout needed
before the real page is created

behatnotneeded

Change-Id: I9e3fc2e9cb14321b8697ac37890b37191ff2efe1
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1696587

Title:
  Problem with Leap2A import and creating custom layout option for user

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  In the view constructor for 17.04+ there is some code that regenerates
  the view_rows_columns info if missing but that relies on the view id
  being known.

  During the Leap2A import process the view id is not known yet - so we
  need the constructor to ignore fixing up view_rows_columns data at
  this point.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1696587/+subscriptions


References