← Back to team overview

mahara-contributors team mailing list archive

[Bug 1708545] A change has been merged

 

Reviewed:  https://reviews.mahara.org/7931
Committed: https://git.mahara.org/mahara/mahara/commit/d1aca37c4f3dcec8c26b4e3d10ff4faa8eaa5e3a
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit d1aca37c4f3dcec8c26b4e3d10ff4faa8eaa5e3a
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Aug 4 10:15:09 2017 +1200

Bug 1708545: Allow placeholder for institution column if not known

So that the Webservice -> Logs page will display things

Also fixed broken lang string

behatnotneeded

Change-Id: If73210e0b2f8986ddd84db4cf3f9d40dcc50565b
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 2b3f239de1f4e19019ba1fda2fa77a8a3f6857de)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1708545

Title:
  Webservices logs page broken due to missing institution value

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  If an external service tries to access webservices with bad token it
  can mean logging of error before the institution value is known
  meaning no institution is set in external_services_logs table.

  So when the Webservices -> Logs page tries to display the logs it
  fails as it can't fetch institution name of 'null'.

  So we need to fix this so that it displays a placeholder string
  instead

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1708545/+subscriptions


References