mahara-contributors team mailing list archive

[Mahara Bot <1708567@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7918
Committed: https://git.mahara.org/mahara/mahara/commit/7f9b6945ed2ed2a38dc5dacee4b37f198e41e822
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 7f9b6945ed2ed2a38dc5dacee4b37f198e41e822
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Aug 4 13:54:13 2017 +1200

Bug 1708567: Avoid error when checking string_exists

We need to avoid the sprintf() error if lang string expects extra args.

We can do this by supplying function check_string rather than
format_string

behatnotneeded

Change-Id: Ibfc2d9a552f2d87b2f5f762bab2ff2ec76a73dca
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1708567

Title:
  string_exists() fuunction causes errors if string expects extra
  arguments

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When checking if a string exists and that string has %s in it for extra arguments it will throw a
  "sprintf(): Too few arguments" error.

  We need to check if string exists without needing to supple the extra
  arguments.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1708567/+subscriptions