← Back to team overview

mahara-contributors team mailing list archive

[Bug 1715260] [NEW] When adding blank annotation via page editor it removes tinymce from field

 

Public bug reported:

Because the form is added again via viewmanager it doesn't have the
tinymce started in it on form error return.

I'll add the code to rewire them back up.

----------

To test:
1) Enable annotation block via Admin -> Extensions
2) Create a page and add annotation block to it
3) Don't fill in anything in annotation field but hit 'save'
You should see the error 'This field is required.'

Before patch the field stops being a TinyMCe field and becomes a normal
one

After patch (and hard refresh of javascript on page edit screen)

You should see the error 'This field is required.' and the field stay a
tinyMCE field

** Affects: mahara
     Importance: High
     Assignee: Robert Lyon (robertl-9)
         Status: In Progress

** Changed in: mahara
    Milestone: None => 17.10.0

** Changed in: mahara
     Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1715260

Title:
  When adding blank annotation via page editor it removes tinymce from
  field

Status in Mahara:
  In Progress

Bug description:
  Because the form is added again via viewmanager it doesn't have the
  tinymce started in it on form error return.

  I'll add the code to rewire them back up.

  ----------

  To test:
  1) Enable annotation block via Admin -> Extensions
  2) Create a page and add annotation block to it
  3) Don't fill in anything in annotation field but hit 'save'
  You should see the error 'This field is required.'

  Before patch the field stops being a TinyMCe field and becomes a
  normal one

  After patch (and hard refresh of javascript on page edit screen)

  You should see the error 'This field is required.' and the field stay
  a tinyMCE field

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1715260/+subscriptions


Follow ups