mahara-contributors team mailing list archive

[Mahara Bot <1708959@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7921
Committed: https://git.mahara.org/mahara/mahara/commit/df38a43eb90005aa0891353702a94b98294924e1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit df38a43eb90005aa0891353702a94b98294924e1
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Aug 7 10:34:57 2017 +1200

Bug 1708959: Fixing test client for testing group creation

There was a problem where one could pass in a valid integer of 0 but
it was getting ignored.

Previously all empty values were ignored

Now if parameter type is integer it will not ignore '0' as a value

Change-Id: I64201db2dbe560ed1dddceadc24b85bdfa72b97b
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1708959

Title:
  Webservice create group missing some settings

Status in Mahara:
  In Progress

Bug description:
  The mahara_group_create_groups function is missing some options

  Including
  - Hide group
  - Hide membership
  - Hide membership from members
  - Participation report
  - Comment notifications

  Also the Shared page notifications option is boolean yet there are 4
  valid states for this option.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1708959/+subscriptions