mahara-contributors team mailing list archive

[Mahara Bot <1718289@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8033
Committed: https://git.mahara.org/mahara/mahara/commit/c544f506664629a032ac27271bd9a4e86d87d7ff
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit c544f506664629a032ac27271bd9a4e86d87d7ff
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Sep 20 08:58:21 2017 +1200

Bug 1718289: Placing auth related title string in auth plugin

Rather than in core lang file to allow thirdparty lang strings to work

behatnotneeded

Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 457d11d15fc66f6b7bd11053ea5fceb89f60ef0e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1718289

Title:
  A string for the auth plugins is stored in core admin.php lang file
  rather than in the plugins

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  This causes problems for third party plugins as they have a broken
  lang string unless the user hacks the core file.

  To test: 
  1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas
  2) Add CAS auth to an institution - The title of the edit screen will be 
  institution | [[casconfig/admin]]

  This string should come from the plugin and not core

  Will need to fix up

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1718289/+subscriptions