← Back to team overview

mahara-contributors team mailing list archive

[Bug 1381184] A change has been merged

 

Reviewed:  https://reviews.mahara.org/8028
Committed: https://git.mahara.org/mahara/mahara/commit/1238a95bd696204a259afcea728582481c534eca
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 1238a95bd696204a259afcea728582481c534eca
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Sep 19 12:25:21 2017 +1200

Bug 1381184: Removing obsolete config value

This value would be present in < 1.10 versions

behatnotneeded

Change-Id: Ic92beea1a209580f798716227a7c53fb600a8869
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1381184

Title:
  need to drop old default email option

Status in Mahara:
  Fix Committed

Bug description:
  Now that we use individual default email options for each activity
  type we need a patch to remove the 'defaultnotificationmethod' from
  config table.

  But the problem is we can't add it to the lib/db/upgrade.php as that
  is run before the upgrade on plugins - nor can we put it in the
  postinst of a plugin because we don't know which plugins will need to
  be updated last post 1.9 - eg if we go from 1.9 -> 1.10 or even 1.9 ->
  1.15 we will need to know the old defaultmethod. But after the initial
  jump we will not need to know about it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1381184/+subscriptions


References