← Back to team overview

mahara-contributors team mailing list archive

[Bug 1716083] A change has been merged

 

Reviewed:  https://reviews.mahara.org/8008
Committed: https://git.mahara.org/mahara/mahara/commit/81273a93e35d4fa7b5591bc0691d156e1069d484
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit 81273a93e35d4fa7b5591bc0691d156e1069d484
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Sat Sep 9 15:53:40 2017 +1200

Bug 1716083: Allow viewing of image thumb when on page we can view

In the results from elasticsearch.

behatnotneeded

Change-Id: I7a74ba6d85a6d1c47c244b3aa1e54e1c6134f519
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1716083

Title:
  elasticsearch image thumbnail missing when viewing media shared by
  another

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Scenario: User A shares a page containing an image with User B

  When user B searches for all things in Elasticsearch they can see the
  page listed under Portfolio tab and can see the image listed under the
  Media tab.

  They however cannot see the thumbnail of the image.

  There is a bit of code missing from the ElasticsearchType_artefact.php
  file. The bit of code that checks that we can see the artefact and the
  view is there. But the viewid is not passed to the get_icon()
  function.

  This patch will add that missing bit in

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1716083/+subscriptions


References