← Back to team overview

mahara-contributors team mailing list archive

[Bug 1513276] A change has been merged

 

Reviewed:  https://reviews.mahara.org/8037
Committed: https://git.mahara.org/mahara/mahara/commit/943ce498fb9884be0f66343a35e8a8924d5d4fb5
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 943ce498fb9884be0f66343a35e8a8924d5d4fb5
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Sep 20 11:38:16 2017 +1200

Bug 1513276: Fixing iframe source mistake

And adding info to help developers

behatnotneeded

Change-Id: Idebbf277cd37f4406874bddb66b4ffef71088750
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1513276

Title:
  Consolidate the iframe sources code

Status in Mahara:
  Fix Committed

Bug description:
  Currently we do a bunch of different things to add allowed iframe
  sources code to the system when we install/upgrade a site

  We need to make it one way only

  Notes:
  lib/upgrade.php, core_postinst(), has a hard-coded list of allowed iframe sources
  if you add the youtube-no-iframes one there, can you also move the prezi one there, and take it out from blocktype/externalvideo::postinst() ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1513276/+subscriptions


References