mahara-contributors team mailing list archive

[Mahara Bot <1566122@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8039
Committed: https://git.mahara.org/mahara/mahara/commit/380a44e1d108e43d526de8f17f2d99dcefcd7a70
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 380a44e1d108e43d526de8f17f2d99dcefcd7a70
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Sep 20 13:24:11 2017 +1200

Bug 1566122: Add token set institution to user's institution

Rather than setting it to 'mahara' by default

behatnotneeded

Change-Id: I7dcd754febe0ab56488aeca941b76e6cce112409
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1566122

Title:
  Select institution with web service auth immediately for token

Status in Mahara:
  Fix Committed

Bug description:
  When a user gets a service access token associated, the institution
  needs to be selected instead of being chosen per default. This means
  that "No institution" can show up when the user is actually a member
  of a different institution.

  This behavior is inconsistent to what you see in "Manage service
  users". There, you can't select your institution, but it is only
  displayed. So it might be an easy fix. :-)

  How to test:

  1) Go to Admin -> Extenstions -> Webservices test client and make sure
  web services is switched on

  2) Go to Institutions and create an institution

  3) Edit institution and for the 'Authentication plugin' dropdown pick
  'Webservices ...' and click 'Add' button then hit submit at bottom of
  form

  4) Go to Admin -> Users and click on a username of a user add them to
  the new institution (bottom of form)

  5) Now change their 'Authentication method' field to the one that is
  the institution name + 'webservice' - click the 'save changes' button

  6) Go back to Admin -> Extenstions -> Webservices and expand the
  'Manage service access tokens' part and search for the user and click
  'Generate token'

  7) On the next form click the 'Back' link at base of form - as we
  don't need to change anything thereat the moment

  8) You should see the user now listed with a 'Token' set. 
  Expected result: The institution should be the one to which you added them earlier
  Actual result: "No institution" is displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1566122/+subscriptions