mahara-contributors team mailing list archive

[Mahara Bot <1721623@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8138
Committed: https://git.mahara.org/mahara/mahara/commit/ba098c6bedf94b860c79ab0594b333a488729344
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.10_STABLE

commit ba098c6bedf94b860c79ab0594b333a488729344
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Fri Oct 6 15:02:11 2017 +1300

Bug 1721623: added plugin's css to be controlled by sass

For both raw and raw_old

Not moving files that are only used for styling
html exported static page:

theme/raw/plugintype/export/html/style/style.css
theme/raw/plugintype/export/html/style/print.css

theme/raw/plugintype/artefact/internal/export/html/style/style.css
	used only in exported static page:
	<path-to-static-page>/files/internal/index.html

theme/raw/plugintype/artefact/resume/export/html/style/style.css
	used only in exported static page:
	<path-to-static-page>/files/resume/index.html

the same for raw_old

Change-Id: Ief02aaee3bd86a30c6cae529953500a3a36ca8c9
behatnotneeded: styles
(cherry picked from commit 80c4b1401dc05573986be5e26c7b660fa57f8b2d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1721623

Title:
  Some core plugins have their own style/style.css files not controlled
  via sass

Status in Mahara:
  Fix Committed

Bug description:
  This means they exist for 'raw' theme but not 'raw_old' theme

  For example: openbadges block, externalfeed block, etc.

  To fix we either need to do:

  A) Copy the same css files to the old raw theme as well (simple
  option)

   or
   
  B) Get these styles handled within sass itself (more robust option)

  This became a problem when we decided to have 2 'root' theme options
  in Mahara. Hopefully we move to only having one again in the future.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1721623/+subscriptions