mahara-contributors team mailing list archive

[Mahara Bot <1724704@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8187
Committed: https://git.mahara.org/mahara/mahara/commit/644b4f23f3bbd2c8751a49768e05fc4c25179fc7
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit 644b4f23f3bbd2c8751a49768e05fc4c25179fc7
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Oct 19 12:08:54 2017 +1300

Bug 1724704: The webservice connection manager 'Add' field missing

It only shows if there are existing connection objects

So will split out the add form from the objects list

behatnotneeded

Change-Id: Iec66f2a8a9bfb744b9673ee9a797246e1a59f420
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 6aa412234dfb13ede969047712c55c5d3f5e16b6)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724704

Title:
  Webservice connection manager not showing 'add connection' form if no
  connection instances exist but a plugin has
  'define_webservice_connections' function set

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  To test this problem:

  1) Edit a plugin file and add in the 'define_webservice_connections'
  function

  eg edit artefact/file/lib.php and add in following function on line 28

      public static function define_webservice_connections() {
          return array(
              array('connection' => 'test',
                  'name' => 'Test this',
                  'notes' => 'Experimental plugin',
                  'version' => get_field('artefact_installed', 'release', 'name', 'file'),
                  'type' => WEBSERVICE_TYPE_REST,
                  'isfatal' => false),
              );
      }

  2) Go to webservice/admin/connections.php?i=mahara in your browser

  Before patch: 
  You should see 'Connection objects' expandable section that is empty but no form to add a new one

  After patch: 
  You should see a form to add a new one placed above the 'Connection objects' expandable section

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724704/+subscriptions