mahara-contributors team mailing list archive

[Niranjan <1729423@xxxxxxxxxxxxxxxxxx>]

URL: https://bugs.launchpad.net/mahara/+bug/1729423

Bug description: Can't choose which comment to make public


Environment to be tested: Master
Browser to be tested: Any browser

Precondition:
1. Normal users ‘User one’ and ‘User two’ should exist.
2. 'User one' created page 'Page 03' and shared it with 'User two'.
3. 'User one' created collection 'Collection' that contains pages 'Page 01' and 'Page 02' and shared it with 'User two'.

Steps to reproduce:

1. Log in as a ‘User two’.
2. On the dashboard under ‘Latest changes I can view’ click on the ‘Page 03’.
3. Enter ‘This is Comment 1’ in the ‘Add comment’ edit box.
4. Switch ‘Make comment public’ to ‘No’.
5. Click the ‘Comment’ button.

Expected result: The comment should display the text ‘This comment is
private’ and a link ‘Make comment public’.

6. Similarly set up 12 more private comments.

Expected result: Comments pagination should be displayed and all
comments are private.

7. Click the ‘Make comment Public’ link for the second comment.

Expected result: The second comment should display as a public comment
and the first comment ‘This is comment 1’ should remain private.

8. Click on the second page of the comments.
9. Click the ‘Make comment Public’ link for the second comment on the second paginated page.

Expected result: The second comment on the second paginated page should display as a public comment. All comments but this one and the second comment on the
first page should still be private.


10. Click the ‘Make comment Public’ button for the first comment on the second paginated page. 

Expected result: The first comment on the second paginated page should
display as a public comment. Comments 2 on the first and second page
should also still be public, and the rest of the comments should remain
private.

11. Log out as 'User two' and log in as 'User one'.
12. Navigate to Main menu > Portfolio > Pages and collections.
13. Click the ‘Collection one’.
14. Select ‘Page 02’ from ‘Navigate to page’ drop down.
15. Set up 3 private comments.
16. Click the ‘Make comment public’ link for the second comment.

Expected result: The second comment should display as a public comment
and the first and third comments should remain private.

17. Click the ‘Make comment public’ link for the first comment.

Expected result: The first and second comments should display as a
public comment and the third comment should remain private.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1729423

Title:
  Can't choose which comment to make public

Status in Mahara:
  In Progress
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  In Progress

Bug description:
  I'm on 17.04.4

  There is multiple private comments on the same item(page or
  collections).

  Whenever i click on "make comment public" other than the first one,
  the first comment available on the page to be made public is made
  public or a request is sent if you're not allowed to. The "make
  comment public" appearing on each comment doesn't refer to the comment
  it is attached to but to the first comment with the link.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1729423/+subscriptions