mahara-contributors team mailing list archive

[Mahara Bot <1726655@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8273
Committed: https://git.mahara.org/mahara/mahara/commit/236a514ccd6f6550851e07be7f2a8c085ff3184b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.10_STABLE

commit 236a514ccd6f6550851e07be7f2a8c085ff3184b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Oct 24 14:37:59 2017 +1300

Bug 1726655: Allow more space for logo in IE11

behatnotneeded

Change-Id: If68427764654a1f92df89453515ee2c3f710bb61
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit a65e3cd952dea467d1c2d899b88fb35d5601a96a)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1726655

Title:
  Mahara logo is cut off at the bottom in IE 11

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  In IE the base of the Mahara logo is being hidden

  I believe it is due to the fact that the image has a height of 45px
  but the container it is in is floated and so lacks height.

  I tried adding 60px height to the containing <a> tag and it looked ok

  Will make a patch so people can test

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1726655/+subscriptions