mahara-contributors team mailing list archive

[Mahara Bot <1572825@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8310
Committed: https://git.mahara.org/mahara/mahara/commit/4e4f4871d36a36325711ef8b24f6fa7e4ad4a954
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.10_STABLE

commit 4e4f4871d36a36325711ef8b24f6fa7e4ad4a954
Author: Cecilia Vela Gurovic <cecilia@xxxxxxxxxxxxxxx>
Date:   Wed Nov 16 10:47:48 2016 +1300

Bug 1572825: added Voki html filter for embed code

Added new html custom filter to allow
voki embed code with javascript tags.

issue with the creation/edition of blocks:

Voki embed code its a javascript code that loads
js functions from a remote file and makes a call to a
AC_Voki_Embed() function

parameters:

function AC_Voki_Embed (width, height, chsm, sc,
transparent, bgcolor, returnFlag, playerType)

The number of parameter makes the difference between
old and new voki code. The old one will have only 7,
the new one will have one more.

The new embed code will have playerType = 1
The function uses an XMLHttpRequest to obtain the
new embed code. When we are loading the page,
there is no problem. But when we are editing or
creating the block, the the connection with the object
gets lost and the embed code is never loaded.
Solution found: reload the page after editing or adding
a block with new voki code.

The old voki code can have
returnFlag = 1 will return a string with the code
returnFlag = 0 will load the embed code in the page (by default)
In this last case, after the function creates the embed code,
it will call document.write('embed code')
if we are loading a page with the embed code, we have no problem
but if we have the page already loaded and we are editing the block
or creating it, the document.write will replace all the html
with the embed code.
Solution found: change parameter of the function so it returns
the code instead, then manually add it in the correct place
of the html.

behatnotneeded

Change-Id: Ieed00b6c6887715b707b8123082a1312f3db1d9c

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1572825

Title:
  voki externalmedia embed code changed

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  A recent support post on the Mahara forums has highlighted that the
  externalmedia flags the voki URL invalid:

  https://mahara.org/interaction/forum/topic.php?id=4007&offset=0&limit=10#post30536

  It appears that the links have changed and will require an update in
  Mahara.

  Previous voki bug: https://bugs.launchpad.net/mahara/+bug/905097

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1572825/+subscriptions