mahara-contributors team mailing list archive

[Mahara Bot <1732297@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8280
Committed: https://git.mahara.org/mahara/mahara/commit/a323c8d83406835131362ca9b700e4a80e26922e
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit a323c8d83406835131362ca9b700e4a80e26922e
Author: Rebecca Blundell <rebeccablundell@xxxxxxxxxxxxxxx>
Date:   Wed Nov 15 16:02:01 2017 +1300

Bug 1732297: Remove unnessesary steps from tests

Done:
Removed checks that user name is visible after login unless it's
related to what's being tested.
where possible added pages in background instead of manually
deleted character_limit, forgot_password and create_group as content was covered in other tests.
checked for other unnessesary "And I should see/ not see" steps
fixed stuff I broke

Change-Id: Ideaff604e49c6ca4b369bf96a3377e38d680d77d

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1732297

Title:
  Remove unnecessary steps from behat tests

Status in Mahara:
  Fix Committed

Bug description:
  In a lot of cases, there are repeated and unnecessary steps being done
  in tests. For instance, a test that has nothing to do with logging in
  will have:

      Given I log in as "admin" with password "Kupuhipa1"
      # Verifying log in was successful
      And I should see "Admin User"

  We don't need to check the login works every time.
  Also, there are a lot of cases where we could add a new page in the background (i.e, it is not a manual add page test) and instead it is done manually in a collection of steps.

  Fixing these things should improve performance.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1732297/+subscriptions