← Back to team overview

mahara-contributors team mailing list archive

[Bug 1735256] A change has been merged

 

Reviewed:  https://reviews.mahara.org/8319
Committed: https://git.mahara.org/mahara/mahara/commit/71d1c2df2112350b1396489b3a0dbc149e928b3b
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 71d1c2df2112350b1396489b3a0dbc149e928b3b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Nov 30 08:29:07 2017 +1300

Bug 1735256: Make sure pagination offset is reset on new search

In the elasticsearch results page when using the search box on that page

behatnotneeded

Change-Id: I1b6fa028c5456623dd656b99b0263ed9a28748dd
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1735256

Title:
  Elasticsearch results not displayed when on paginated page

Status in Mahara:
  Fix Committed

Bug description:
  Problem: When doing a subsequent search in elasticsearch after
  paginating to non first page of initial results. If the new results
  are greater than 0 but less than 10 no results are displayed but the
  tab indicates results exist.

  To test:
  1) On a site with elasticsearch enabled and indexed - first do full search (by leaving search field blank) and have more than 10 results in 'Text' tab
  2) Go to page 2 of the results
  3) Now search again using search field above tabs (NOT the one at top of page) for something that appears in 'Text' tab only a few times, eg country for user
  4) Should display count in 'Text' tab but not the actual result.

  This is due to the ajax call not setting 'offset' back to 0 for the
  pagination

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1735256/+subscriptions


References