mahara-contributors team mailing list archive

[Mahara Bot <1732046@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8277
Committed: https://git.mahara.org/mahara/mahara/commit/3b64fa1f862b9fdf3b6a72c8d7a0320d6202ac81
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 3b64fa1f862b9fdf3b6a72c8d7a0320d6202ac81
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Nov 14 11:48:00 2017 +1300

Bug 1732046: Fixing up the country codes within country lib file

Fixing some mistakes from Bug 1514647 where we forgot to update the
Country class, which is used as part of the import/export leap2A process

Also adjusting getoptions_country() so that it fetches the 2 char
codes from the Country class rather than repeating code.

behatnotneeded

Change-Id: I901e6a1827da31fbdbb1ac4c9fb8e46b247b5dc2
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1732046

Title:
  Need to consolidate country code information for Mahara 18.04.0

Status in Mahara:
  Fix Committed

Bug description:
  Currently we have lib/country.php containing the 'Country' class which list the 2 and 3 char codes
  And we have getoptions_country() in lib/web.php that list the 2 char codes

  We don't need both - we should make the Country class the preferred
  one and fetch our 2 char codes for getoptions_country() from the
  class.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1732046/+subscriptions