mahara-contributors team mailing list archive

[Mahara Bot <1733938@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8299
Committed: https://git.mahara.org/mahara/mahara/commit/8e48d4c84f4358396bafa0cbe65283c997582879
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 8e48d4c84f4358396bafa0cbe65283c997582879
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Nov 23 09:01:28 2017 +1300

Bug 1733938: Allow 'ESC' key to cancel adding of a block

When on the 'add block' popup

behatnotneeded

Change-Id: I8bb59e9bedd5a64e6b59330aa5e2fc2aba3ef639
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1733938

Title:
  Duplicate key error on block edit page in Postgres

Status in Mahara:
  Fix Committed

Bug description:
  It is possible to get this error:

  Failed to get a recordset: postgres8 error: [-5: ERROR: duplicate key
  value violates unique constraint "blocinst_vierowcolord_uk" DETAIL:
  Key (view, "row", "column", "order")=(16, 1, 1, 1) already exists.] in
  EXECUTE("INSERT INTO "block_instance" ("id", "blocktype", "title",
  "configdata", "view", "column", "order", "row") VALUES (?, ?, ?, ?, ?,
  ?, ?, ?)")Command was: INSERT INTO "block_instance" ("id",
  "blocktype", "title", "configdata", "view", "column", "order", "row")
  VALUES (?, ?, ?, ?, ?, ?, ?, ?) and values was
  (id:8261,blocktype:textbox,title:Note,configdata:a:0:{},view:16,column:1,order:1,row:1)

  To reproduce:
  1. Create a new page
  2. Click on the Note block
  3. Do not click on Add nor on Cancel, but press ESC key (because you just realised that you have selected the wrong text block)
  4. Click on the Text block
  5. Click on the Add button

  The problem here is the using of 'ESC' key is not cleaning up info
  about old block, so is trying to save the old and new block with same
  block position

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1733938/+subscriptions