mahara-contributors team mailing list archive

[Mahara Bot <1737851@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8348
Committed: https://git.mahara.org/mahara/mahara/commit/1cbf546387e28cbae16dddbfb97472ceeda47a40
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 1cbf546387e28cbae16dddbfb97472ceeda47a40
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Dec 13 12:36:31 2017 +1300

Bug 1737851: Avoid submitted list check for loggedout user

When viewing a public group

behatnotneeded

Change-Id: I71a55f6bea018969a8499ca04d9c57754aa9a0de
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1737851

Title:
  Unable to view public group homepage when logged out

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  When we have the follow in play:

  1) A group that has "public" = 1
  2) a group homepage where the group pages block has $configdata['showsubmitted'] = 1

  When a logged out user tries to view the group homepage we get an
  error:

  group_user_access: user argument should be an integer

  This is because the logged out user can't be compared to a group
  member/admin

  We need to add a $USER->is_logged-in() check before going down that
  rabbithole

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1737851/+subscriptions