mahara-contributors team mailing list archive

[Mahara Bot <1735442@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8356
Committed: https://git.mahara.org/mahara/mahara/commit/4fcadff5b94af015694b6715d1dbc54bc9971cf3
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit 4fcadff5b94af015694b6715d1dbc54bc9971cf3
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Dec 12 13:55:17 2017 +1300

Bug 1735442: Primary buttons in custom theme need border

Before it was transparent, which was fine when header background
colour was dark. But when it is light, eg white, then we can't see
where the button finishes and the page start.

Have made the border the same colour as text of button.

To test: re-save custom theme for institution with some actual change
so system saves new info

behatnotneeded

Change-Id: I925599d51d1c3446700c5439c1aeffda1383d150
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 9280e348f18f2af6080fe5c3c53ec45317144fc7)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1735442

Title:
  Buttons w/ white background are invisible in the configurable theme

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  This is a regression to an earlier version of Mahara.

  When you choose a white header background in the configurable theme,
  the button color turns white and doesn't have a border.

  We used to have a border around it though so that the buttons can be
  seen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1735442/+subscriptions