mahara-contributors team mailing list archive

[Mahara Bot <1750925@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8538
Committed: https://git.mahara.org/mahara/mahara/commit/d374ec0bfb3492d463e4b3c17641e3d8e9e0dea0
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit d374ec0bfb3492d463e4b3c17641e3d8e9e0dea0
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Feb 22 11:18:42 2018 +1300

Bug 1750925: Tidy up database for blocks that set their title via plugin

The 'myviews', 'mygroups', 'myfriends', 'wall' blocks all set their
title via the plugin so we don't need to set their title in
block_instance table.

Currently we are saving the 'myviews' one with broken lang string title

behatnotneeded

Change-Id: Ie583678e2a1bb650513f873024f49269b6e66912
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1750925

Title:
  Blocks that have override_instance_title() don't need to record their
  title in block_instance table

Status in Mahara:
  Fix Committed

Bug description:
  I was gettign confused when I saw '[[title/blocktype.myviews]]' being
  saved and was not seeing the broken string on the frontend.

  I'll make a patch to clean that all up

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1750925/+subscriptions