← Back to team overview

mahara-contributors team mailing list archive

[Bug 1752389] [NEW] Warning Undefined property: stdClass::$name on upgrade

 

Public bug reported:

We have a mechanism where is the database information about a plugin is newer than the plugin's file information we:
 (in production mode) warn the user before upgrade
 (not in production mode) display the problem on admin dashboard after upgrade

But there is a problem if the plugin doesn't set a display name or a
fallback $config->name

We need to allow the plugin to display it's path name so as to be
slightly helpful.


To test:
Have a fully upgraded site then:
1) Set the config version back one day, eg:
UPDATE config SET value = value::int - 100 WHERE field = 'version';

2) Update a plugin's installed value forward one day, eg:
UPDATE artefact_installed SET version = version::int + 100 WHERE name = 'resume';
UPDATE search_installed SET version = version::int + 100 WHERE name = 'elasticsearch';

Before patch - you should see warning when not in production mode

** Affects: mahara
     Importance: Medium
     Assignee: Robert Lyon (robertl-9)
         Status: In Progress

** Changed in: mahara
       Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
     Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara
    Milestone: None => 18.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1752389

Title:
  Warning Undefined property: stdClass::$name on upgrade

Status in Mahara:
  In Progress

Bug description:
  We have a mechanism where is the database information about a plugin is newer than the plugin's file information we:
   (in production mode) warn the user before upgrade
   (not in production mode) display the problem on admin dashboard after upgrade

  But there is a problem if the plugin doesn't set a display name or a
  fallback $config->name

  We need to allow the plugin to display it's path name so as to be
  slightly helpful.

  
  To test:
  Have a fully upgraded site then:
  1) Set the config version back one day, eg:
  UPDATE config SET value = value::int - 100 WHERE field = 'version';

  2) Update a plugin's installed value forward one day, eg:
  UPDATE artefact_installed SET version = version::int + 100 WHERE name = 'resume';
  UPDATE search_installed SET version = version::int + 100 WHERE name = 'elasticsearch';

  Before patch - you should see warning when not in production mode

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1752389/+subscriptions


Follow ups