mahara-contributors team mailing list archive

[Mahara Bot <1755674@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8651
Committed: https://git.mahara.org/mahara/mahara/commit/2a65c6d7ec3990aed232b4e2a9b37caaa345f44b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    18.04_STABLE

commit 2a65c6d7ec3990aed232b4e2a9b37caaa345f44b
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Thu Mar 15 08:50:36 2018 +1300

Bug 1755674: check tinyMCE is not used in anonymous comments

behatnotneeded

Change-Id: I17b0520d692e418d48629af790f11bb5f6682cf1
(cherry picked from commit b86b8a04e84c1fd5cd1ddcc453bb898e1c95f322)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755674

Title:
  tinyMCE not defined error in comment on SE colection

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  to test:

  
  Go to admin menu-> Extensions -> Plugin admin and enable annotations
  create a page and add an annotation to it
  share it with Public
  log out and go to the collection first page (not SE view table)
  try to leave a comment as anonymous user

  the page will be stuck loading and the comment is never submitted
  in the browser's console we can see the error:

  Uncaught ReferenceError: tinyMCE is not defined
      at isTinyMceUsed (annotation.js?v=7998:14)
      at addFeedbackSuccess (viewmenu.js?v=7998:37)
      at Object.window.pieformHandlers.(/view/anonymous function) [as add_feedback_form] (https://mahara/lib/pieforms/static/core/pieforms.js?v=7998:239:60)
      at sendResult (view.php?id=7:4)
      at onload (view.php?id=7:7)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755674/+subscriptions