mahara-contributors team mailing list archive

[Mahara Bot <1755611@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8690
Committed: https://git.mahara.org/mahara/mahara/commit/e42528eae749777a4ffc8eebb6c6b774b5058b23
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit e42528eae749777a4ffc8eebb6c6b774b5058b23
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Mar 8 10:56:30 2018 +1300

Bug 1755611: Should not call non static function statically in framework
module

Get these deprecated warnings:
Non-static method PluginModuleFramework::add_matrix_to_db() should not be called
statically in htdocs/module/framework/lib.php on line 56
Non-static method PluginModuleFramework::matrix_is_valid_json() should not be called
statically in htdocs/module/framework/lib.php on line 107

behatnotneeded

Change-Id: I959b1364926a32b88fe9aaea147b5d38de6884b0
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 53914399050b50da11776710c9f03354dfff19bd)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755611

Title:
  Should not call non static function statically in framework module

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Get these deprecated warnings: 
  Non-static method PluginModuleFramework::add_matrix_to_db() should not be called statically in htdocs/module/framework/lib.php on line 56 
  Non-static method PluginModuleFramework::matrix_is_valid_json() should not be called statically in htdocs/module/framework/lib.php on line 107

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755611/+subscriptions