mahara-contributors team mailing list archive

[Mahara Bot <1757283@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8695
Committed: https://git.mahara.org/mahara/mahara/commit/18e5acaa322dd831dcd326a9de33316377d5b12e
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.10_STABLE

commit 18e5acaa322dd831dcd326a9de33316377d5b12e
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Mar 21 11:47:32 2018 +1300

Bug 1757283: Use more generic javascript syntax to help IE

The includes() method not available for IE 11

behatnotneeded

Change-Id: Ice40becaacb391bc7b4f85ebf533f9b049e2a5a2
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 0465c54d32824decd8d17e3d10f02d0d3077cc1e)
(cherry picked from commit a4b81e7deac0bc29773ca559505b590226802965)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757283

Title:
  The views.js file uses the javascript 'includes' function but this is
  not available to IE11

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  We have:
   if (embedjs.includes("AC_Voki_Embed")) {

  We need:
   if (embedjs.indexOf("AC_Voki_Embed") !== -1) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757283/+subscriptions