mahara-contributors team mailing list archive

[Rob Hardy <r.hardy@xxxxxxxxxxxx>]

This may be related to an issue we have found with Medial Media Library.

The issue I found is that ampersands appear to always be being encoded
as HTML entities when written into the page (i.e. & becomes &) - I
presume this is a feature of the Smarty templating engine, as I can see
the ampersands in the URLs are not encoded in the database, nor when
they are assigned to the template. This doesn't cause an issue when the
(iframe-based) embed code is written directly into the HTML of the page,
as it is when Retract is set to "Yes" or "No".

However, when the block is set to "Automatically retract", the embed
code is loaded from a jQuery function when the block header is clicked.
The ampersands are encoded when this function is written into the page,
but jQuery appears to be re-encoding the ampersands (so that &
becomes &). This is visible once the video is loaded, by
inspecting via Firefox web developer tools, and using "Edit as HTML".

At the moment, the only fix I've found for this feels a bit hacky: to
use a JavaScript replace() to decode the ampersands before they are
passed to the onclick handler (see attached patch).

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742349

Title:
  External(Kaltura) video doesn't play when block is on auto-retract

Status in Mahara:
  Confirmed

Bug description:
  
  Hi,
  This one is similar to bug report - Bug #1565669
  Embedded Kaltura video in Mahara not displaying when the setting retractable is set to Automatically retract.
  The video will play when set to Retractable=Yes or Retractable=No.

  This one is similar to bug report - Bug #1565669

  
  Example Embed:
  <iframe id="kaltura_player" src="https://cdnapisec.kaltura.com/p/2246991/sp/224699100/embedIframeJs/uiconf_id/38197461/partner_id/2246991?iframeembed=true&playerId=kaltura_player&entry_id=0_t2juqhe6&flashvars[streamerType]=auto&amp;flashvars[localizationCode]=en&amp;flashvars[leadWithHTML5]=true&amp;flashvars[sideBarContainer.plugin]=true&amp;flashvars[sideBarContainer.position]=left&amp;flashvars[sideBarContainer.clickToClose]=true&amp;flashvars[chapters.plugin]=true&amp;flashvars[chapters.layout]=vertical&amp;flashvars[chapters.thumbnailRotator]=false&amp;flashvars[streamSelector.plugin]=true&amp;flashvars[EmbedPlayer.SpinnerTarget]=videoHolder&amp;flashvars[dualScreen.plugin]=true&amp;&wid=0_lp5uyok9"; width="400" height="285" allowfullscreen webkitallowfullscreen mozAllowFullScreen frameborder="0" title="Kaltura Player"></iframe>

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742349/+subscriptions