mahara-contributors team mailing list archive

[Mahara Bot <1766833@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8813
Committed: https://git.mahara.org/mahara/mahara/commit/4d812254aadb91d6f50141ddd610deaeccd8ccc1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 4d812254aadb91d6f50141ddd610deaeccd8ccc1
Author: Nicolas Dunand <Nicolas.Dunand@xxxxxxx>
Date:   Fri Apr 27 09:33:19 2018 +1200

Bug 1766833: increase maxlayoutrows

1. raises this limit to 20
2. shows smaller preview rows for layouts having >= 60 rows

behatnotneeded

Change-Id: I4aabed614a6c2a649d62eca38f1f70e3a1bc7853

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1766833

Title:
  maxlayoutrows is too low

Status in Mahara:
  Fix Committed

Bug description:
  The maximum number of rows for a view is arbitrarily set to 6 in
  lib/view.php ($maxlayoutrows), which may be too small for some uses.

  The code also references some file (layoutpreview.php) which is not
  present (as an explanation for this limitation ?).

  Discussion on https://mahara.org/interaction/forum/topic.php?id=6413
  has Robert Lyon and Aaron Wells stating (back in 2014-2015) that this
  could be changed.

  Therefore I propose a small modification, which :

  1. raises this limit to 20
  2. shows smaller preview rows for layouts having >= 60 rows

  Attached patch for Mahara 17.x-18.04

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1766833/+subscriptions