← Back to team overview

mahara-contributors team mailing list archive

[Bug 1763517] A change has been merged

 

Reviewed:  https://reviews.mahara.org/8810
Committed: https://git.mahara.org/mahara/mahara/commit/65475755b51c9d03150a814d38aedfa92a15d9aa
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 65475755b51c9d03150a814d38aedfa92a15d9aa
Author: Kevin Dibble <kevin.dibble@xxxxxxxxxxxxxxxxxxx>
Date:   Mon Apr 16 10:25:12 2018 +1200

Bug 1763517: Comments can't be deleted when work is submitted for
marking

behatnotneeded

Change-Id: I402d90f2e89466aa266b28451b7511ba35a2305a

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1763517

Title:
  Comments can't be deleted when work is submitted for marking

Status in Mahara:
  Fix Committed

Bug description:
  Version:  Mahara 18.04.0
  Os: Mac
  Database: mysql
  Browser: chrome: Version 65.0.3325.181 (Official Build) (64-bit)

  Issue:
  When work is submitted for Marking, all comments and feedback during the marking process can be deleted by the user.

  Possible solution:
  While work is locked, to hide the delete comment form for annotation comments (Smart evidence feedback) and to check if work is in a submitted state before deleting page comments.

  Users can still show/hide comments from public as needed. Creators of
  comments can still edit them (during the edit timeframe), but will not
  be able to delete them while the page is under review.

  Attached is a patch with this possible solution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1763517/+subscriptions


References