mahara-contributors team mailing list archive

[Mahara Bot <1765264@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8808
Committed: https://git.mahara.org/mahara/mahara/commit/9eefc1c84dc98079844390bb56f7f89f3c5f5ce3
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 9eefc1c84dc98079844390bb56f7f89f3c5f5ce3
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Apr 19 16:00:22 2018 +1200

Bug 1765264: Group id not needed to be array for group_get_admin_ids()

A mistake made in the patch for Bug 1367539

behatnotneeded

Change-Id: If0b27c356887483532693153f0b8936b7d12eb14
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1765264

Title:
  Error when deleting a user relating to the group quota

Status in Mahara:
  Fix Committed

Bug description:
  [WAR] 50 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion
  Call stack (most recent first):
    * log_message("Array to string conversion", 8, true, true, "/home/robertl/clients/catalyst/mahara-clients/htdo...", 45) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/errors.php:521
    * error(8, "Array to string conversion", "/home/robertl/clients/catalyst/mahara-clients/htdo...", 45, array(size 7)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/adodb/adodb-exceptions.inc.php:45
    * ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR:  invalid input syntax for integer: "Array"", "SELECT "member"
          FROM "group_member"
        ...", array(size 1), object(ADODB_postgres8)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/adodb/adodb-exceptions.inc.php:80
    * adodb_throw("postgres8", "adodb_throw", -1, "ERROR:  invalid input syntax for integer: "Array"", "SELECT "member"
          FROM "group_member"
        ...", array(size 1), object(ADODB_postgres8)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/adodb/adodb.inc.php:313
    * ADODB_TransMonitor("postgres8", "adodb_throw", -1, "ERROR:  invalid input syntax for integer: "Array"", "SELECT "member"
          FROM "group_member"
        ...", array(size 1), object(ADODB_postgres8)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/adodb/adodb.inc.php:1264
    * ADOConnection->_Execute("SELECT "member"
          FROM "group_member"
        ...", array(size 1)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/adodb/adodb.inc.php:1224
    * ADOConnection->Execute("SELECT "member"
          FROM "group_member"
        ...", array(size 1)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/adodb/adodb.inc.php:1714
    * ADOConnection->GetCol("SELECT "member"
          FROM "group_member"
        ...", array(size 1)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/dml.php:891
    * get_column_sql("SELECT "member"
          FROM "group_member"
        ...", array(size 1)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/group.php:1605
    * group_get_admin_ids(array(size 1)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/artefact/file/lib.php:1877
    * ArtefactTypeFile::notify_groups_threshold_exceeded(array(size 1)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/artefact/file/lib.php:439
    * PluginArtefactFile::eventlistener_savedeleteartefact("deleteartefact", object(ArtefactTypeFile)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/mahara.php:1789
    * call_static_method("PluginArtefactFile", "eventlistener_savedeleteartefact", "deleteartefact", object(ArtefactTypeFile)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/mahara.php:2084
    * handle_event("deleteartefact", object(ArtefactTypeFile), array(size 8)) at /home/robertl/clients/catalyst/mahara-clients/htdocs/artefact/lib.php:719
    * ArtefactType->delete() at /home/robertl/clients/catalyst/mahara-clients/htdocs/artefact/file/lib.php:1363
    * ArtefactTypeFile->delete() at /home/robertl/clients/catalyst/mahara-clients/htdocs/artefact/lib.php:702
    * ArtefactType->delete() at /home/robertl/clients/catalyst/mahara-clients/htdocs/artefact/file/lib.php:2003
    * ArtefactTypeFolder->delete() at /home/robertl/clients/catalyst/mahara-clients/htdocs/lib/user.php:1612
    * delete_user("4839") at /home/robertl/clients/catalyst/mahara-clients/htdocs/admin/cli/delete_inactive_users.php:154


  The problem is the group_get_admin_ids() is called with an array
  rather than an id

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1765264/+subscriptions