mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

** Changed in: mahara/17.04
       Status: Confirmed => Invalid

** Changed in: mahara/17.10
       Status: Confirmed => Invalid

** Changed in: mahara/18.04
       Status: Confirmed => Invalid

** Changed in: mahara/18.10
       Status: In Progress => Invalid

** Changed in: mahara/17.04
    Milestone: 17.04.8 => None

** Changed in: mahara/17.10
    Milestone: 17.10.5 => None

** Changed in: mahara/18.04
    Milestone: 18.04.1 => None

** Changed in: mahara/18.10
    Milestone: 18.10.0 => None

** Changed in: mahara/17.04
   Importance: High => Undecided

** Changed in: mahara/17.10
   Importance: High => Undecided

** Changed in: mahara/18.04
   Importance: High => Undecided

** Changed in: mahara/18.10
   Importance: High => Undecided

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1771950

Title:
  Fixing delete wallpost still has a problem

Status in Mahara:
  Invalid
Status in Mahara 17.04 series:
  Invalid
Status in Mahara 17.10 series:
  Invalid
Status in Mahara 18.04 series:
  Invalid
Status in Mahara 18.10 series:
  Invalid

Bug description:
  In Bug 1767220 we fixed up the problem with showing the delete
  wallpost button

  Except we failed to fix one scenario and that was checking if the
  viewer of the page is an institutional admin of the page owner.

  In the original code we sent the $owner id through as an integer, ie
  intval($owner)

  But now we send it as a string

           $item->deletable =
  PluginBlocktypeWall::can_delete_wallpost($item->from, $owner);

  And the check in can_delete_wallpost() is for a User object or integer
  so fails and throws error

  We need to fix up the passing of the id to be integer again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1771950/+subscriptions