mahara-contributors team mailing list archive

[Mahara Bot <1772773@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8880
Committed: https://git.mahara.org/mahara/mahara/commit/00ed9a98c74002c1ccdd9a902c3aafef19d439e9
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 00ed9a98c74002c1ccdd9a902c3aafef19d439e9
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Wed May 23 14:17:01 2018 +1200

Bug 1772773: call render_items in the static way

behatnotneeded

Change-Id: Idcd2689e6c196a6604e5f4706fb9019c4f0e3c88

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1772773

Title:
  Need to call render_items in the static way

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  There is this error reported by a forum member

  error(2048, "Non-static method PluginBlocktypeMyviews::render_i...",
  "/var/www/mahara1804/blocktype/myviews/lib.php", 109, array(size 8))
  at /var/www/mahara1804/blocktype/myviews/lib.php:109

  See https://mahara.org/interaction/forum/topic.php?id=8260&post=33051

  Looking at the places we use render_items() they are not called in a
  static way

  (unlike calls to render_instance() )

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1772773/+subscriptions