mahara-contributors team mailing list archive

[Mahara Bot <1774309@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8933
Committed: https://git.mahara.org/mahara/mahara/commit/6f4f15a5cfa169f6acf798bbd1826e91d125b86b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit 6f4f15a5cfa169f6acf798bbd1826e91d125b86b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu May 31 13:44:27 2018 +1200

Bug 1774309: Only redirect with QUERY_STRING when it exists

If trying to access a page requiring login the system remembers the
path (QUERY_STRING) you were trying to access when login is successful

But if you login from the homepage there can be no QUERY_STRING set

Noticed when doing behat tests

behatnotneeded

Change-Id: I38cf1f6df7432d70ced5fe5df84bd56b47f1f163
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 1c3d039b0f7c57cfe57410e510293e8d7cdd1d19)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1774309

Title:
  Getting an Undefined index: QUERY_STRING when logging in

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  If trying to access a page requiring login the system remembers the
  path (QUERY_STRING) you were trying to access. So when login is
  successful it will redirect to that page.

  But if you login from the homepage there can be no QUERY_STRING to
  redirect to

  Noticed when doing behat tests

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1774309/+subscriptions