mahara-contributors team mailing list archive

[Mahara Bot <1771362@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8866
Committed: https://git.mahara.org/mahara/mahara/commit/bc25beec2cf7d0d7c1d8a5575ddfe27a5e4e5f05
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit bc25beec2cf7d0d7c1d8a5575ddfe27a5e4e5f05
Author: Mark Webster <mark.webster@xxxxxxxxxxxxxxx>
Date:   Thu May 17 11:25:16 2018 +0100

Bug 1771362: Fix timezone issues.

Adds timezone dropdown the site settings. If no timezone selected
it uses site settings country to determine correct timezone and sets
that in the database.
PHP and DB session timezones will then assume this setting for all times.

This makes setting $cfg->dbtimezone obsolete - there is a warning to
admins to update their timezone setting on admin dashboard.

Limitations:
- A timezone or country MUST be selected in site options.

- Will not correct existing incorrect times, as no timezone info was
stored in the DB for dates/times, so it's impossible to determine what timezone
was used when saving.

- Changing the timezone will not adjust the display of existing times, for the
same reason.

behatnotneeded

Change-Id: I34c64cd51ece6758e76dd8c37007dcb316005845

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1771362

Title:
  Times reported inaccurately when DB timezone does not match PHP
  timezone

Status in Mahara:
  Fix Committed

Bug description:
  See
  https://wiki.mahara.org/index.php/System_Administrator%27s_Guide/Installing_Mahara/Troubleshooting#Q:_Time_zone_problems_.2F_Mahara_is_showing_incorrect_times_for_forum_posts
  for a full breakdown of the problem.

  TL,DR Mahara has no support for multiple timezones and assumes that
  the PHP date.timezone and the database server's timezone are
  identical. If they are not, then all dates that get stored into the
  database and displayed back to the user will be off by (Database UTC
  offset - PHP UTC offset).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1771362/+subscriptions