mahara-contributors team mailing list archive

[Mahara Bot <1774309@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8943
Committed: https://git.mahara.org/mahara/mahara/commit/d9ce7d924f086358a27e00bd99138faddbb75e7a
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit d9ce7d924f086358a27e00bd99138faddbb75e7a
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Jun 6 09:29:20 2018 +1200

Bug 1774334: Correcting redirect on login for site in subdirectory

The fix in Bug 1774309 fails to work correctly when the site
is in a subdirectory of the apache root.

To test:
1) Adjust your site's apache file and set the DocumentRoot to be
parent of htdocs
2) Change the 'wwwroot' db value for site to include the 'htdocs/' bit
3) Restart the apache server
4) Go to site, adding 'htdocs/' to url
5) Try logging in

before patch: end up not found page with url containing two 'htdocs/'

after patch: end up at correct place

behatnotneeded

Change-Id: Ic5e1de2c5edaf96bbdd9b2403f0f65e45a4b80c0
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1774309

Title:
  Getting an Undefined index: QUERY_STRING when logging in

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  If trying to access a page requiring login the system remembers the
  path (QUERY_STRING) you were trying to access. So when login is
  successful it will redirect to that page.

  But if you login from the homepage there can be no QUERY_STRING to
  redirect to

  Noticed when doing behat tests

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1774309/+subscriptions