mahara-contributors team mailing list archive

[Mahara Bot <1758181@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8984
Committed: https://git.mahara.org/mahara/mahara/commit/d278b69382c58edf9a853fafae66c4eb9f12849c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit d278b69382c58edf9a853fafae66c4eb9f12849c
Author: Sarah Kirby <sarahkirby@xxxxxxxxxxxxxxx>
Date:   Mon Jul 2 09:57:20 2018 +1200

Bug 1758181: Hide background colour of comment

container div if comments are not present or enabled

behatnotneeded

Change-Id: I7fed5fb90c34fcf955fc8551dacf128792e68cd7

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758181

Title:
  Extra div field when comments are turned off on page or artefact
  details page

Status in Mahara:
  Fix Committed

Bug description:
  Environment tested: Master
  Browser tested: MS Edge (Virtualbox)

  ===================
  Manual Test Script
  ===================

  1) user has a portfolio page with one resume field block that is set to retract on it 
  2) user views Page displayed 
  3) user clicks the details link just below the one resume field block
  4) user is redirected to a page only showing the one resume field block

  Actual result: Page is displayed with the one resume field block and
  is retracted.✔ Just under the block area is a very light grey
  background section on the page ✘

  
  Expected result: Light grey background section should not be displayed because this artefact cannot have a comment.

  NOTE: 
  - this also happens when you have a page that does not allow comments. (could be any page without comments)
  - this is visible in themes that have a background for the comment area 

  Catalyst QA

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758181/+subscriptions