← Back to team overview

mahara-contributors team mailing list archive

Re: [Bug 1775479] Re: obsolete code for displaying comments

 

Plizz unsubscribe me from the domain. This is not what my school wanted to
join for my e -Portifolio

Michael Singini

On Sun, 15 Jul 2018 at 03:10, Kristina Hoeppner <1775479@xxxxxxxxxxxxxxxxxx>
wrote:

> ** No longer affects: mahara/17.04
>
> ** No longer affects: mahara/17.10
>
> ** No longer affects: mahara/18.04
>
> ** Changed in: mahara
>        Status: New => Confirmed
>
> ** Changed in: mahara
>    Importance: Undecided => Medium
>
> ** Changed in: mahara
>      Assignee: (unassigned) => Rebecca Blundell (rjb-dev)
>
> --
> You received this bug notification because you are subscribed to Mahara
> 18.04.3.
> https://bugs.launchpad.net/bugs/1775479
>
> Title:
>   obsolete code for displaying comments
>
> Status in Mahara:
>   Confirmed
>
> Bug description:
>   We have old code not used anymore for displaying comment list from a
> text note
>   in view/view.php ln 308
>
>   It was added in commit e03327b0f68d6c7bc40cd04cfed441f42b802ba3 in
>   15.04
>
>   for
>     "Adjusting the textbox so it can show/hide comments (Bug #1037531)
>
>       The comments will be displayed (or hidden) below the block by
> clicking
>       on the 'Comments (x)' link. There is also a 'close' link at the
> bottom
>       of the comment list as well to close them."
>
>   We don't use this anymore since now, when clicking on coment(x) link,
>   they are displayed in a right side modal panel.
>
>   We have to check what other obsolete related code we need to clean.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mahara/+bug/1775479/+subscriptions
>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1775479

Title:
  obsolete code for displaying comments

Status in Mahara:
  Confirmed

Bug description:
  We have old code not used anymore for displaying comment list from a text note
  in view/view.php ln 308

  It was added in commit e03327b0f68d6c7bc40cd04cfed441f42b802ba3 in
  15.04

  for 
    "Adjusting the textbox so it can show/hide comments (Bug #1037531)
      
      The comments will be displayed (or hidden) below the block by clicking
      on the 'Comments (x)' link. There is also a 'close' link at the bottom
      of the comment list as well to close them."

  We don't use this anymore since now, when clicking on coment(x) link,
  they are displayed in a right side modal panel.

  We have to check what other obsolete related code we need to clean.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1775479/+subscriptions


References