mahara-contributors team mailing list archive

[Mahara Bot <1779600@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8991
Committed: https://git.mahara.org/mahara/mahara/commit/dd7ca4d47e2c5e331ca8799bf6840a879375a58b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit dd7ca4d47e2c5e331ca8799bf6840a879375a58b
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Fri Jul 6 13:35:31 2018 +1200

Bug 1779600: removing slideshow.js

This js file was loaded when calling
function get_instance_javascript() in
artefact/file/blocktype/gallery/lib.php

The line that included that file was removed when adding bootstrap
There are no calls to the only function defined in slideshow.js,
I think is safe to remove the file.

behatnotneeded

Change-Id: Iddcc6419a06cfccebdd3d243680ee653fd5cae2d

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1779600

Title:
  Remove slideshow.js

Status in Mahara:
  Fix Committed

Bug description:
  we are using bootstrap carousel instead, according to first lines in
  file artefact/file/blocktype/gallery/js/slideshow.js

  and couldn't find any reference to this file in the code

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1779600/+subscriptions