mahara-contributors team mailing list archive

[Mahara Bot <1760732@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8783
Committed: https://git.mahara.org/mahara/mahara/commit/8cac996b6eb7efbe04e9974f7eefb62ffdde2b55
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 8cac996b6eb7efbe04e9974f7eefb62ffdde2b55
Author: Rebecca Blundell <rebecca.blundell@xxxxxxxxxxxxxxx>
Date:   Thu Apr 5 18:30:51 2018 +1200

Bug 1760732: Add warning for upgrade of configurable themes

Add 'customthemeupdate' flags for any institution to the
institution_config table if:
- the upgrade is from 16.10 or before
- and the institution is using a configurable theme

If there are institutions with 'customthemeupdate' set we add a warning
that the institution settings need to be re-saved.

Once the settings for an institution have been re-saved we clear the
flag for that institution

Steps to test:
1) Have a 16.04 version site
2) Create three institutions, two with a configurable themes
3) Checkout the patch and run upgrade
4) On clicking 'Continue' you should see the warning message
5) On going to Admin dashboard you should see message there also
6) Edit / save one of the institions
7) Confirm that institution is not listed
8) Do for the other and see warning now gone

behatnotneeded

Change-Id: I844d8e8bcb9be81a29f36cb101da1c61b41b10a9

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1760732

Title:
  Configurable theme not displaying correctly after upgrade

Status in Mahara:
  Fix Committed

Bug description:
  Upgrading Mahara from 15.10_STABLE to 18.04_STABLE (rc3) on postgres
  with firefox:

  I restored an existing database for 15.10, which included a user with
  a configurable theme.

  After the upgrade, the background colour has disappeared in the
  heading and only shows in the search box.(see attached screenshot.)

  This can be fixed by re-saving the settings under the institution,
  however, we should at least consider adding a warning with this info.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1760732/+subscriptions