mahara-contributors team mailing list archive

[Mahara Bot <1782729@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9024
Committed: https://git.mahara.org/mahara/mahara/commit/6c5373d6abd9728a19bb839f6da384ef83377549
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 6c5373d6abd9728a19bb839f6da384ef83377549
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Jul 23 12:19:22 2018 +1200

Bug 1782729: Adjust skin form to submit via javascript

In the past there was 2 filebrowser fields, body background and view
background, in the skin edit form and this meant we couldn't submit
the form by js as it confused things.

But now we only have the body background image option so I've altered
the form so that it submits via javascript.

In doing so it gets the changing folder to work as expected as well.

I've also restricted the images one can use to non-profile ones as
that was causing an error on valid image check.

behatnotneeded

Change-Id: Ia11d3ce6073d15d2c60727d3abbdf31b6a93993b
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1782729

Title:
  Uploading new image as skin background gives error

Status in Mahara:
  Fix Committed

Bug description:
  Hello

  I was testing in preparation for an upgrade from v 17.04 to 18.04 and
  found that I couldn't upload a new image as a background to a skin.
  I've tried on demo.mahara.org and this is what I've found:

  I created a new skin.  Went into the Background tab and clicked on Add
  a File.  Moving between folders brings me back to the Background tab;
  I would expect it to list the files in the selected folder.   This
  happens even if there are image files in the selected folder.

  Clicking on Add a File again then shows the list of files and I can
  then select an image file and close the dialog box.   I am taken back
  to the Background tab and the image file is displayed.

  Clicking on Save at that point gives:

  Mahara Demo: Site unavailable
  A nonrecoverable error occurred. This probably means you have encountered a bug in the system 

  Suspect there's an explanation for this.  If I first upload an image
  file (256x256, PNG, 34k) into my Content-Files area, I can go through
  the above process select the image file and it saves OK.  The image
  files I had tried previously on the demo site was percy.png which is a
  profile image, 11k, PNG, 100x100 but this error has occurred
  consistently on our dev site regardless of the image selected.

  Regards
  Marion

  Browser Firefox 61.0.1
  Windows 7
  Not sure of db on demo.mahara.org; I think our dev site has MySQL

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1782729/+subscriptions