mahara-contributors team mailing list archive

[Mahara Bot <1776816@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8969
Committed: https://git.mahara.org/mahara/mahara/commit/6213b3d19bb5ad23ef331ed573224c32437a61e6
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 6213b3d19bb5ad23ef331ed573224c32437a61e6
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Thu Jun 21 17:31:31 2018 +1200

Bug 1776816: Update jquery-mobile to 1.5.0-alpha1

for compatibility with jquery 3

behatnotneeded

Change-Id: I5f00e9ff5ec5bcfb9d39abe5c6fd97e3a6e58a33

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1776816

Title:
  jquery-mobile warnings with jquery 3

Status in Mahara:
  Fix Committed

Bug description:
  jQuery 3 is deprecating bind and unbind methods. We already have the latest stable version for jquery.mobile.
  There is a new alpha version but it doesn't change the touch event code that we actually use for mahara
  https://github.com/jquery/jquery-mobile/blame/1.5.0-alpha.1/js/events/touch.js

  since it hasn't been change in 2 years, we need to fix this bit of
  code.

  According to the jquery site 
  https://github.com/jquery/jquery-migrate/blob/master/warnings.md
  the solution is to change the method call to use .on() or .off()

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1776816/+subscriptions