mahara-contributors team mailing list archive

[Mahara Bot <1775722@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8992
Committed: https://git.mahara.org/mahara/mahara/commit/bc4b90406bf5617909e795c35d46d734b173a3d4
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit bc4b90406bf5617909e795c35d46d734b173a3d4
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Fri Jul 6 15:19:01 2018 +1200

Bug 1775722: remove obsolete code in page custom layout

remove #basiclayouthelp & #customlayouthelp reference

help icons are not used anymore, not even  before
unifying the Edit content/Edit layout/Choose skin screens.

remove #createcustomlayouttitle reference

it was used to hide/show the custom layout section
custom layout is not in a collapsible anymore

behatnotneeded

Change-Id: I588ce277370f8e3734b2a43fbc3e5b77c8eae1fb

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1775722

Title:
  obsolete code in page custom layout settings

Status in Mahara:
  Fix Committed

Bug description:
  in js/customlayout.js line 225 we have
      $('#togglecustomlayoutoptions').hide();

  the element '#togglecustomlayoutoptions' used to contain the "Create custom layout" section in page edit screen, so it could be hidden by clicking on the section title. 
   The "Create custom layout" is not hidden anymore, and the element '#togglecustomlayoutoptions' was removed from the html.

  The call to $('#togglecustomlayoutoptions').hide() should be removed
  and also check what other code is not used anymore.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1775722/+subscriptions