mahara-contributors team mailing list archive

[Mahara Bot <1779586@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8986
Committed: https://git.mahara.org/mahara/mahara/commit/f3418d6c9fc602038ffe075b1915fa8280612e9b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit f3418d6c9fc602038ffe075b1915fa8280612e9b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Jul 2 11:26:17 2018 +1200

Bug 1779586: Update the copied page description correctly

We need to run it thru the EmbeddedImage::prepare_embedded_images()
function

behatnotneeded

Change-Id: I29c8375249d3b57ec0c7999751ebcd06bdd2e95e
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1779586

Title:
  Copying page fails to update page description embedded image correctly

Status in Mahara:
  Fix Committed

Bug description:
  When we have a page description containing an embedded image and we
  share it to another user and allow copying.

  When they copy the page they see the embedded image in the 'settings'
  form but if they don't save that form but go to view the page they
  can't see the image.

  The image is correctly copied from old user to new user, but:

  1) The row for artefact_file_embedded table is not added
  2) The embedded link in description text is not fully formed, eg, 

  it looks like "artefact/file/download.php?file=189&amp;embedded=1"
  it should be like "artefact/file/download.php?file=189&amp;embedded=1&amp;description=20"

  So the copying / embedding needs to be fixed up

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1779586/+subscriptions