mahara-contributors team mailing list archive

[Mahara Bot <1752743@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8905
Committed: https://git.mahara.org/mahara/mahara/commit/c6c6c295b4872e9e3f871862484af6a9a0cb3291
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit c6c6c295b4872e9e3f871862484af6a9a0cb3291
Author: Rebecca Blundell <rebecca.blundell@xxxxxxxxxxxxxxx>
Date:   Tue May 29 13:50:31 2018 +1200

Bug 1752743: replace php 7.2 deprecated functions

replaced each() with foreach in core code.
replaced create_function() with anonymous function in core code.

Also removed some functions that were not used anymore

behatnotneeded

Change-Id: I300396a1ec04c75d7882b7ec5c9de76c3763e70d

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1752743

Title:
  Need to tidy up code for deprecated php functions

Status in Mahara:
  Fix Committed

Bug description:
  The following functions that are used in Mahara will be deprecated for
  PHP 7.2

  - create_function()
  - each()

  So should be replaced with better code.

  the create_function() can be replaced with the use of an anonymous
  function and each() should be altered to work with a foreach loop
  instead

  And the function assert() should be checked to make sure the argument
  is not a string to be evaluated

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1752743/+subscriptions