← Back to team overview

mahara-contributors team mailing list archive

[Bug 1785938] A change has been merged

 

Reviewed:  https://reviews.mahara.org/9056
Committed: https://git.mahara.org/mahara/mahara/commit/66e7468ad0856faad3a029cc772e5b4572632ea8
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 66e7468ad0856faad3a029cc772e5b4572632ea8
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Aug 8 13:30:18 2018 +1200

Bug 1785938: Fixing gallery and changing slimbox2 to fancybox3

Things done with this patch:

1) Changed the 'Use photo frame' option from being a plugin variable
to being an instance config variable

2) Added back in the css for the giving the gallery images photo frame
borders

3) Get the non-square thumbs to render correctly spaced on load

4) Swapped the slimbox2 to fancybox3 and allowed the block itself to
control when to put content into head data

behatnotneeded

Change-Id: I397be45f2347588988b663b25b560d8ab876afe1
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1785938

Title:
  slimbox2 upgrade to fix problems with jquery

Status in Mahara:
  Fix Committed

Bug description:
  Also fix other problems with gallery as well like:

  Site setting for using photoframe not working

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1785938/+subscriptions


References