mahara-contributors team mailing list archive

[Kristina Hoeppner <1777971@xxxxxxxxxxxxxxxxxx>]

** Tags added: code-cleanup

** Changed in: mahara
    Milestone: 18.10.0 => 19.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1777971

Title:
  jquery-ui timepicker- old code needs to be removed

Status in Mahara:
  Confirmed

Bug description:
  when upgrading jquery-ui to 1.12.1 I found a customization in the file 
  jquery-ui/js/jquery-ui.min.js that was made when this message was added to js/jquery/jquery-ui/README.Mahara

  * Added call to function after datepicker arrow key is pressed - to
  allow the year arrows to be re-added on day change

  that was added in commit 
  here, a function add_prev_next_year() was defined and added to jquery-ui/js/jquery-ui.min.js

  that function was removed in commit 8d796e7ca04b6df776b5deeb07cf38b9c7b037c0
  for Bug #1744191: Updated the datepicker to use the bootstrap one

  there is no need to add extra code to jquery-ui.min.js
  and it would be good to check what else is in the code but not needed anymore

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1777971/+subscriptions