mahara-contributors team mailing list archive

[Mahara Bot <1779049@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/8988
Committed: https://git.mahara.org/mahara/mahara/commit/6307cc7fdfbf8c824bc7637d90317198242217ab
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 6307cc7fdfbf8c824bc7637d90317198242217ab
Author: Yaju Mahida <mahida@xxxxxxxxxx>
Date:   Mon Jul 2 13:21:39 2018 +1000

Bug 1779049: Make mysql_has_trigger_privilege() work better / more
robust

behatnotneeded

Author:    Yaju Mahida <mahida@xxxxxxxxxx>

Change-Id: I4a2c51a4a7af0842cc37ba710cdaec6c2d053d75

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1779049

Title:
  Make mysql_has_trigger_privilege() work better / more robust

Status in Mahara:
  Fix Committed

Bug description:
  Currently the function mysql_has_trigger_privilege() checks if we can
  make triggers on the database but if we have a problem during upgrade
  we can get in the state where the 'testtable' exists (not being
  cleaned up)

  Also mysql_has_trigger_privilege() gets checked on every step of db
  upgrade

  We need to do 2 things

  1) Make the need to run mysql_has_trigger_privilege() more infrequent by setting a flag in the db config table if the check passes
  2) Make the check more robust so that if the 'testtable' already exists (was not cleaned up) we handle that in a better manner, eg drop trigger if exists then try adding trigger again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1779049/+subscriptions